Skip to content

bpo-30619: fix #2326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 22, 2017
Merged

bpo-30619: fix #2326

merged 1 commit into from
Jun 22, 2017

Conversation

khyox
Copy link
Contributor

@khyox khyox commented Jun 22, 2017

Following bug #30619.

It was the example (and not the text) which is consistent with PEP 483:

Corollary: Union[..., object, ...] returns object

So, the correction is simply to substitute 'former' for 'latter'.

@khyox
Correct bug python#30619
8e49dd2 
Following http://bugs.python.org/issue30619.

From line 942, it was the example (and not the text) which is consistent with PEP 483:

    Corollary: Union[..., object, ...] returns object

So, the correction is to substitute 'former' for 'latter'.
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@khyox khyox changed the title Correct bug #30619 Fix bug #30619 Jun 22, 2017
@khyox khyox changed the title Fix bug #30619 Fix issue #30619 Jun 22, 2017
@khyox khyox changed the title Fix issue #30619 Fix bpo-30619 Jun 22, 2017
@mlouielu
Copy link
Contributor

mlouielu commented Jun 22, 2017 •
edited
Loading

@khyox Hello and welcome, you will need to reform your title to start with bpo-30619: <your title>, so that the bedevere may get the correct bpo issue number!

@khyox khyox changed the title Fix bpo-30619 bpo-30619: fix Jun 22, 2017
ilevkivskyi
ilevkivskyi approved these changes Jun 22, 2017
View reviewed changes
Copy link
Member

@ilevkivskyi ilevkivskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

I hope someone with commit rights will merge this after you sign the CLA.

@khyox
Copy link
Contributor Author

khyox commented Jun 22, 2017 •
edited
Loading

Thanks @mlouielu and @ilevkivskyi ! CLA just signed.

@Mariatta Mariatta added needs backport to 3.6 docs Documentation in the Doc dir labels Jun 22, 2017
@Mariatta Mariatta merged commit 6580c19 into python:master Jun 22, 2017
@Mariatta
Copy link
Member

Thanks @khyox and congrats on your first contribution to CPython 🎉

@khyox
Copy link
Contributor Author

khyox commented Jun 22, 2017

Thank you very much @Mariatta!! Just a tiny bit, but it's a honor indeed! I hope to keep contributing in the near future.

@khyox khyox deleted the patch-1 branch June 22, 2017 18:10
Mariatta pushed a commit to Mariatta/cpython that referenced this pull request Jun 23, 2017
@khyox @Mariatta
[3.6] bpo-30619: Clarify typing.Union documentation (pythonGH-2326)
c0d00f5 
When a class and its subclass are present, the latter is skipped.
(cherry picked from commit 6580c19)
@bedevere-bot
Copy link

GH-2337 is a backport of this pull request to the 3.6 branch.

Mariatta added a commit that referenced this pull request Jun 23, 2017
@Mariatta
[3.6] bpo-30619: Clarify typing.Union documentation (GH-2326) (GH-2337)
8baf78b 
When a class and its subclass are present, the latter is skipped.
(cherry picked from commit 6580c19)
Mariatta pushed a commit to Mariatta/cpython that referenced this pull request Jun 23, 2017
@khyox @Mariatta
[3.5] bpo-30619: Clarify typing.Union documentation (pythonGH-2326)
e526f62 
When a class and its subclass are present, the latter is skipped.
(cherry picked from commit 6580c19)
@bedevere-bot
Copy link

GH-2338 is a backport of this pull request to the 3.5 branch.

Mariatta added a commit that referenced this pull request Jun 23, 2017
@Mariatta
[3.5] bpo-30619: Clarify typing.Union documentation (GH-2326) (GH-2338)
ce1bd6a 
When a class and its subclass are present, the latter is skipped.
(cherry picked from commit 6580c19)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mariatta Mariatta Mariatta approved these changes

@ilevkivskyi ilevkivskyi ilevkivskyi approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@khyox @the-knights-who-say-ni @mlouielu @Mariatta @bedevere-bot @ilevkivskyi