Skip to content

bpo-30709: Fixed bad getter example from Doc/Descriptor#Properties #2339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2017

Conversation

anqur
Copy link
Contributor

@anqur anqur commented Jun 23, 2017

  • I recreated the branch that is current even with master
  • Previous conversation: bpo-30709: bad getter from Descriptor#Properties example #2288
  • About the commit,
    • The purpose of obj in the example is implicit
    • As an argument the obj will cause errors when using Cell('b10').value because it expects more arguments, but 1 given

@mention-bot
Copy link

@anqurvanillapy, thanks for your PR! By analyzing the history of the files in this pull request, we identified @birkenfeld, @serhiy-storchaka and @rhettinger to be potential reviewers.

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@Mariatta Mariatta merged commit b066edf into python:master Jun 23, 2017
@Mariatta
Copy link
Member

Thanks @anqurvanillapy and congrats on your first contribution to CPython 🎉

Mariatta pushed a commit to Mariatta/cpython that referenced this pull request Jun 23, 2017
Mariatta pushed a commit to Mariatta/cpython that referenced this pull request Jun 23, 2017
Mariatta pushed a commit to Mariatta/cpython that referenced this pull request Jun 23, 2017
Mariatta added a commit that referenced this pull request Jun 23, 2017
Mariatta added a commit that referenced this pull request Jun 23, 2017
Mariatta added a commit that referenced this pull request Jun 23, 2017
@anqur anqur deleted the patch-1 branch June 23, 2017 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants