Skip to content

Correct return type in Modules/_ssl.c::sslmodule_legacy #23609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 2, 2020
Merged

Correct return type in Modules/_ssl.c::sslmodule_legacy #23609

merged 1 commit into from
Dec 2, 2020

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Dec 2, 2020 •
edited
Loading

Fixing

/home/shager/cpython-buildarea/custom.edelsohn-aix-ppc64/build/Modules/_ssl.c: In function 'sslmodule_legacy':
/home/shager/cpython-buildarea/custom.edelsohn-aix-ppc64/build/Modules/_ssl.c:6419:16: warning: return makes integer from pointer without a cast [-Wint-conversion]
         return NULL;
                ^~~~

@pablogsal pablogsal requested a review from tiran as a code owner December 2, 2020 03:38
@pablogsal pablogsal merged commit 93a0ef7 into python:master Dec 2, 2020
pablogsal added a commit to pablogsal/cpython that referenced this pull request Dec 2, 2020
@pablogsal
[3.9] Correct return type in Modules/_ssl.c::sslmodule_legacy (python…
faff711 
…GH-23609).

(cherry picked from commit 93a0ef7)

Co-authored-by: Pablo Galindo <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Dec 2, 2020
@python python deleted a comment from miss-islington Dec 2, 2020
@python python deleted a comment from miss-islington Dec 2, 2020
@python python deleted a comment from miss-islington Dec 2, 2020
@python python deleted a comment from bedevere-bot Dec 2, 2020
@pablogsal pablogsal deleted the correct_return branch December 2, 2020 06:12
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@pablogsal @adorilson
Correct return type in Modules/_ssl.c::sslmodule_legacy (pythonGH-23609)
eea3ee2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiran tiran Awaiting requested review from tiran

Assignees

@pablogsal pablogsal

Labels
skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pablogsal @the-knights-who-say-ni @bedevere-bot