Skip to content

bpo-42584 : Update Windows installer to use SQLite 3.34.0 #23675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 5, 2021

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Dec 7, 2020

@erlend-aasland
Copy link
Contributor Author

@zooba Would you prefer to update the sources repo yourself, or do you want me to create a PR for the amalgamation sources over there?

@wbrycki
Copy link

wbrycki commented Dec 7, 2020

Sorry for my question maybe not 100% related to the PR, but:
Is sqlite3 python module installing its own version of sqlite3 system lib?
I'm having trouble basically with the same, to tell sqlite3 python module to use sqlite 3.34 and not some older one provided by the system (debian buster in this case (stable distro), which comes with the older version).

What I have until now is that I compile from source locally and I'm overwriting a symlink to sqlite3 lib:
ln -sfn $(pwd)/sqlite-3.34/sqlite3 $(which sqlite3)

but the still, in python, when I import sqlite3 module and check the version with sqlite3.sqlite_version, the older one is shown. Do you maybe know, how can I configure sqlite3 to use a lib from different installation path?

@erlend-aasland
Copy link
Contributor Author

Is sqlite3 python module installing its own version of sqlite3 system lib?

The Windows and macOS installers found on python.org build their own SQLite library.

I'm having trouble basically with the same, to tell sqlite3 python module to use sqlite 3.34 and not some older one provided by the system (debian buster in this case (stable distro), which comes with the older version).

Try this:

bash$ SQLITE_CFLAGS="-I<path to SQLite 3 include dir>"
bash$ SQLITE_LDFLAGS="-L<path to SQLite 3 lib dir>"
bash$ ./configure CFLAGS=$SQLITE_CFLAGS LDFLAGS=$SQLITE_LDFLAGS
bash$ make

@wbrycki
Copy link

wbrycki commented Dec 8, 2020

Is sqlite3 python module installing its own version of sqlite3 system lib?

The Windows and macOS installers found on python.org build their own SQLite library.

I'm having trouble basically with the same, to tell sqlite3 python module to use sqlite 3.34 and not some older one provided by the system (debian buster in this case (stable distro), which comes with the older version).

Try this:

bash$ SQLITE_CFLAGS="-I<path to SQLite 3 include dir>"
bash$ SQLITE_LDFLAGS="-L<path to SQLite 3 lib dir>"
bash$ ./configure CFLAGS=$SQLITE_CFLAGS LDFLAGS=$SQLITE_LDFLAGS
bash$ make

I used binary version from here: https://github.com/coleifer/pysqlite3
Thanks anyway!

@zooba zooba merged commit dd74c01 into python:master Jan 5, 2021
@erlend-aasland erlend-aasland deleted the sqlite-3.34/windows branch January 5, 2021 22:02
@miss-islington
Copy link
Contributor

Thanks @erlend-aasland for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington
Copy link
Contributor

Sorry @erlend-aasland and @zooba, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker dd74c01d3bd2833f72ffe400a1d10b8583c0ba6a 3.9

@miss-islington
Copy link
Contributor

Thanks @erlend-aasland for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @erlend-aasland and @zooba, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker dd74c01d3bd2833f72ffe400a1d10b8583c0ba6a 3.8

zooba pushed a commit to zooba/cpython that referenced this pull request Jan 5, 2021
@bedevere-bot
Copy link

GH-24132 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Jan 5, 2021
zooba added a commit that referenced this pull request Jan 6, 2021
zooba pushed a commit to zooba/cpython that referenced this pull request Jan 6, 2021
@bedevere-bot
Copy link

GH-24133 is a backport of this pull request to the 3.8 branch.

zooba added a commit that referenced this pull request Jan 6, 2021
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants