Skip to content

[3.8] bpo-26407: Do not mask errors in csv. (GH-20536) #24021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 1, 2021

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Dec 31, 2020

Unexpected errors in calling the iter method are no longer
masked by TypeError in csv.reader(), csv.writer.writerow() and
csv.writer.writerows().
(cherry picked from commit c88239f)

https://bugs.python.org/issue26407

Unexpected errors in calling the __iter__ method are no longer
masked by TypeError in csv.reader(), csv.writer.writerow() and
csv.writer.writerows()..
(cherry picked from commit c88239f)

Co-authored-by: Serhiy Storchaka <[email protected]>
@terryjreedy
Copy link
Member

GHA tests do not give an error report. Travis says failure (unrelated) in test_nntplib

ERROR: test_descriptions (test.test_nntplib.NetworkedNNTP_SSLTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/python/cpython/Lib/test/test_nntplib.py", line 250, in wrapped
    meth(self)
  File "/home/travis/build/python/cpython/Lib/test/test_nntplib.py", line 99, in test_descriptions
    desc = descs[self.GROUP_NAME]
KeyError: 'comp.lang.python'
======================================================================
FAIL: test_description (test.test_nntplib.NetworkedNNTP_SSLTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/python/cpython/Lib/test/test_nntplib.py", line 250, in wrapped
    meth(self)
  File "/home/travis/build/python/cpython/Lib/test/test_nntplib.py", line 85, in test_description
    self.assertIn("Python", desc)
AssertionError: 'Python' not found in ''

Pipelines says more or less same including on Windows.  I will rerun in case transient.

@terryjreedy terryjreedy reopened this Dec 31, 2020
@serhiy-storchaka serhiy-storchaka merged commit 6dffa67 into python:3.8 Jan 1, 2021
@serhiy-storchaka serhiy-storchaka deleted the backport-c88239f-3.8 branch January 1, 2021 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants