bpo-42823: Update frame.f_lineno before any call to the (C) tracing function. #24150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nimizes breakage and ensures PyFrame_GetLineNumber is efficient.
|
Skipping NEWS as there is nothing new here |
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 13, 2021
…ythonGH-24150) * Minimizes breakage of C extensions and ensures PyFrame_GetLineNumber is efficient.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minimizes breakage and ensures PyFrame_GetLineNumber is efficient.
This PR sets the C field
frame.f_linenoto the actual line number before any call to a tracing function, and sets it back to zero after the call. This:frame.f_linenoalways holds same value as the Python attributePyFrame_GetLineNumber()efficient, as it will not need to do any computation when called within a tracing function.Should have no effect when tracing is turned off.
https://bugs.python.org/issue42823