Skip to content

Fix typo in what's new. bidst_wheel -> bdist_wheel #24234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 21, 2021
Merged

Fix typo in what's new. bidst_wheel -> bdist_wheel #24234

merged 1 commit into from
Jan 21, 2021

Conversation

ravcio
Copy link
Contributor

@ravcio ravcio commented Jan 17, 2021 •
edited by miss-islington
Loading

bidst_wheel -> bdist_wheel

Automerge-Triggered-By: GH:Mariatta

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@ravcio, @AvendiSchool

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Jan 17, 2021
@iritkatriel iritkatriel requested a review from Mariatta January 17, 2021 18:19
@iritkatriel
Copy link
Member

@ravcio Would you like to sign the CLA? It's not strictly required for fixing a typo, but it will be necessary when you make larger contributions in the future.

Mariatta
Mariatta approved these changes Jan 18, 2021
View reviewed changes
Copy link
Member

@Mariatta Mariatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Mariatta Mariatta changed the title Docs: Fix spelling Fix typo in what's new. bidst_wheel -> bdist_wheel Jan 18, 2021
@Mariatta
Copy link
Member

Once CLA is signed this will get merged automatically. Thanks and congrats on your first contribution to CPython!

ravcio
ravcio commented Jan 20, 2021
View reviewed changes
Copy link
Contributor Author

@ravcio ravcio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment

@Mariatta
Copy link
Member

This PR is authored by @ravcio but the git commit was made by @AvendiSchool.
Both would need to sign the CLA.
Also, is there a reason that the PR was made by a different person than the one who made the commit?

If the two accounts are owned by one person, would it be possible for you to adjust the PR such that the PR author and the committer are the same?

@ravcio ravcio force-pushed the master branch 3 times, most recently from 9acb17a to 55a00e5 Compare January 21, 2021 09:40
@miss-islington
Copy link
Contributor

@ravcio: Status check is done, and it's a success ✅ .

1 similar comment
@miss-islington
Copy link
Contributor

@ravcio: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor

Sorry, I can't merge this PR. Reason: Base branch was modified. Review and try the merge again..

@miss-islington
Copy link
Contributor

Sorry, I can't merge this PR. Reason: 2 of 4 required status checks are expected..

1 similar comment
@miss-islington
Copy link
Contributor

Sorry, I can't merge this PR. Reason: 2 of 4 required status checks are expected..

@miss-islington
Copy link
Contributor

@ravcio: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 6cd5b01 into python:master Jan 21, 2021
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@ravcio @adorilson
Fix typo in what's new. bidst_wheel -> bdist_wheel (pythonGH-24234)
2d9df10 
bidst_wheel -> bdist_wheel

Automerge-Triggered-By: GH:Mariatta
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes

@Mariatta Mariatta Mariatta approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ravcio @the-knights-who-say-ni @iritkatriel @Mariatta @miss-islington @bedevere-bot