bpo-43002: Fix description of behaviour of an exception class in 'from' clause #24303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdickinson
added
needs backport to 3.8
needs backport to 3.9
|
|
cool-RR
approved these changes
Jan 23, 2021
|
This PR is stale because it has been open for 30 days with no activity. |
Thanks, but I'm not quite sure what to do with this information. Reviews are welcome. I'll plan to merge within the next couple of weeks. |
|
This PR is stale because it has been open for 30 days with no activity. |
|
Thanks @mdickinson for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 11, 2021
…ythonGH-24303) (cherry picked from commit 79650d0) Co-authored-by: Mark Dickinson <[email protected]>
|
GH-25341 is a backport of this pull request to the 3.9 branch. |
|
GH-25342 is a backport of this pull request to the 3.8 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 11, 2021
…ythonGH-24303) (cherry picked from commit 79650d0) Co-authored-by: Mark Dickinson <[email protected]>
mdickinson
added a commit
that referenced
this pull request
Apr 11, 2021
…H-24303) (GH-25342) (cherry picked from commit 79650d0) Co-authored-by: Mark Dickinson <[email protected]> Co-authored-by: Mark Dickinson <[email protected]>
mdickinson
added a commit
that referenced
this pull request
Apr 11, 2021
…H-24303) (GH-25341) (cherry picked from commit 79650d0) Co-authored-by: Mark Dickinson <[email protected]> Co-authored-by: Mark Dickinson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a
raise <expr> from <expr2>statement,<expr2>is permitted to be an exception instance, an exception class, orNone. The reference manual suggests that in the first two cases, the value of<expr2>is attached directly to the raise exception as the__cause__. But in the implementation, an exception class is first instantiated before being attached to the raised exception:cpython/Python/ceval.c
Lines 4758 to 4763 in b745a61
This PR fixes the documentation to match the implementation.
https://bugs.python.org/issue43002