Add annotations to example of overload implementation #24310
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the body of the implementation of an overloaded function to be type-checked it must be annotated. This updates the overloaded example to show this behaviour. Similar to python/mypy#3369
|
So the PR template says that "Most PRs will require an issue number. Trivial changes, like fixing a typo, do not need an issue." however it looks like I can't add the "skip issue" or "skip news" labels to this PR since I don't have commit access. Could a member of the core core dev / triage team add these labels to this one line documentation change please. |
|
I disagree that the body "must" be annotated. This depends on the type checker used and the flags/configuration passed. I personally find the added annotation here a distraction. |
|
This PR is stale because it has been open for 30 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the body of the implementation of an overloaded function to be type-checked it must be annotated.
This updates the overloaded example to show this behaviour.
Similar to python/mypy#3369