-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
Trivial edit for clarity #2453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Trivial edit for clarity #2453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think 'innermost' is more accurate/precise than 'smallest', in this context.
Mariatta
approved these changes
Jun 27, 2017
Thanks @regexaurus and congrats on your first contribution to CPython 🎉 |
regexaurus
added a commit
to regexaurus/cpython
that referenced
this pull request
Jun 28, 2017
Clarify that the break statement breaks out of the innermost enclosing for or while loop. (cherry picked from commit 36fc896)
regexaurus
added a commit
to regexaurus/cpython
that referenced
this pull request
Jun 28, 2017
Clarify that the break statement breaks out of the innermost enclosing for or while loop. (cherry picked from commit 36fc896)
regexaurus
added a commit
to regexaurus/cpython
that referenced
this pull request
Jun 28, 2017
Clarify that the break statement breaks out of the innermost enclosing for or while loop. (cherry picked from commit 36fc896)
GH-2457 is a backport of this pull request to the 3.6 branch. |
GH-2458 is a backport of this pull request to the 3.5 branch. |
GH-2459 is a backport of this pull request to the 2.7 branch. |
Mariatta
pushed a commit
that referenced
this pull request
Jun 28, 2017
Clarify that the break statement breaks out of the innermost enclosing for or while loop. (cherry picked from commit 36fc896)
Mariatta
pushed a commit
that referenced
this pull request
Jun 28, 2017
Clarify that the break statement breaks out of the innermost enclosing for or while loop. (cherry picked from commit 36fc896)
Mariatta
pushed a commit
that referenced
this pull request
Jun 28, 2017
Clarify that the break statement breaks out of the innermost enclosing for or while loop. (cherry picked from commit 36fc896)
Thanks for the backports! |
You're very welcome! Thanks for your patience. I promise to try and not be too annoying while I learn git/hub. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think 'innermost' is more accurate/precise than 'smallest', in this context.