bpo-43327: Fix the docs for PyImport_ImportFrozenModuleObject() #24659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The docs state that PyImport_ImportFrozenModuleObject() returns a new reference, but it actually returns an int. The name of this function's first parameter must be specified in Doc/data/refcounts.dat. The line for the name parameter will correspond to the function's return value if the parameter name is not given (as mentioned in a comment at the top of Doc/data/refcounts.dat).
|
This PR is stale because it has been open for 30 days with no activity. |
github-actions
bot
removed
the
stale
kumaraditya303
added
needs backport to 3.10
kumaraditya303
approved these changes
Nov 27, 2022
|
Thanks @ZackerySpytz for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
|
GH-99807 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 27, 2022
…onGH-24659) The docs stated that PyImport_ImportFrozenModuleObject() returns a new reference, but it actually returns an int. (cherry picked from commit 62a5dc1) Co-authored-by: Zackery Spytz <[email protected]> Co-authored-by: Kumar Aditya <[email protected]>
|
GH-99808 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 27, 2022
…onGH-24659) The docs stated that PyImport_ImportFrozenModuleObject() returns a new reference, but it actually returns an int. (cherry picked from commit 62a5dc1) Co-authored-by: Zackery Spytz <[email protected]> Co-authored-by: Kumar Aditya <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Nov 27, 2022
…4659) The docs stated that PyImport_ImportFrozenModuleObject() returns a new reference, but it actually returns an int. (cherry picked from commit 62a5dc1) Co-authored-by: Zackery Spytz <[email protected]> Co-authored-by: Kumar Aditya <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Nov 27, 2022
…4659) The docs stated that PyImport_ImportFrozenModuleObject() returns a new reference, but it actually returns an int. (cherry picked from commit 62a5dc1) Co-authored-by: Zackery Spytz <[email protected]> Co-authored-by: Kumar Aditya <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docs state that PyImport_ImportFrozenModuleObject() returns a
new reference, but it actually returns an int.
The name of this function's first parameter must be specified in
Doc/data/refcounts.dat. The line for the name parameter will
correspond to the function's return value if the parameter name is
not given (as mentioned in a comment at the top of
Doc/data/refcounts.dat).
https://bugs.python.org/issue43327
Automerge-Triggered-By: GH:kumaraditya303