Skip to content

bpo-43368: Fix fetching empty bytes on SQLite. #24706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 3, 2021
Merged

bpo-43368: Fix fetching empty bytes on SQLite. #24706

merged 1 commit into from
Mar 3, 2021

Conversation

felixxm
Copy link
Contributor

@felixxm felixxm commented Mar 2, 2021 •
edited by bedevere-bot
Loading

@felixxm felixxm requested a review from berkerpeksag as a code owner March 2, 2021 12:18
@erlend-aasland
Copy link
Contributor

This requires a NEWS item, since it's a regression in an official release.

@felixxm
Copy link
Contributor Author

felixxm commented Mar 2, 2021

This requires a NEWS item, since it's a regression in an official release.

Added.

erlend-aasland
erlend-aasland approved these changes Mar 2, 2021
View reviewed changes
Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM w/minor nitpicks. I'll add error handling in a separate PR. Thanks for spotting this!

@felixxm
Copy link
Contributor Author

felixxm commented Mar 2, 2021

@erlend-aasland Thanks for reviews 👍

berkerpeksag
berkerpeksag approved these changes Mar 3, 2021
View reviewed changes
Copy link
Member

@berkerpeksag berkerpeksag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'll rerun tests since one of the required ones was failed.

@berkerpeksag
Copy link
Member

I thought it was a flaky test, but turns out master is broken. I'll merge once master is green.

@felixxm
Copy link
Contributor Author

felixxm commented Mar 3, 2021

@berkerpeksag Thanks 👍

@felixxm
Copy link
Contributor Author

felixxm commented Mar 3, 2021

Rebased from master.

@berkerpeksag berkerpeksag merged commit 3b4b2cf into python:master Mar 3, 2021
@felixxm felixxm deleted the fix-issue-43368 branch March 3, 2021 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berkerpeksag berkerpeksag berkerpeksag approved these changes

@erlend-aasland erlend-aasland erlend-aasland approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@felixxm @erlend-aasland @berkerpeksag @the-knights-who-say-ni @bedevere-bot