Skip to content

bpo-43369: sqlite3_column_text() and sqlite3_column_blob() failures now raise MemoryError #24723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 4, 2021
Merged

bpo-43369: sqlite3_column_text() and sqlite3_column_blob() failures now raise MemoryError #24723

merged 6 commits into from
Mar 4, 2021

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Mar 3, 2021 •
edited by bedevere-bot
Loading

Erlend E. Aasland added 2 commits March 3, 2021 15:22
berkerpeksag
berkerpeksag requested changes Mar 4, 2021
View reviewed changes
@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@erlend-aasland
Copy link
Contributor Author

Thank you for reviewing, @berkerpeksag. I have made the requested changes; please review again.

@bedevere-bot
Copy link

Thanks for making the requested changes!

@berkerpeksag: please review the changes made to this pull request.

berkerpeksag
berkerpeksag approved these changes Mar 4, 2021
View reviewed changes
Copy link
Member

@berkerpeksag berkerpeksag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Hopefully we aren't going to introduce another regression this time :)

@erlend-aasland
Copy link
Contributor Author

LGTM! Hopefully we aren't going to introduce another regression this time :)

Let's hope so :) Thanks, Berker!

@berkerpeksag berkerpeksag merged commit e161ec5 into python:master Mar 4, 2021
@erlend-aasland erlend-aasland deleted the bpo-43369 branch March 4, 2021 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berkerpeksag berkerpeksag berkerpeksag approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@erlend-aasland @bedevere-bot @berkerpeksag @the-knights-who-say-ni