bpo-29630: don't run code on tab-completion #248
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use inspect.getattr_static to check if dealing with a property, and avoid calling getattr on it.
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow these steps to rectify the issue:
Thanks again to your contribution and we look forward to looking at it! |
|
Closing, not a bug! |
akruis
pushed a commit
to akruis/cpython
that referenced
this pull request
May 21, 2021
Mention, that module "stackless" must be imported, to enable the extended pickling capabilities. (cherry picked from commit c5cabba)
akruis
pushed a commit
to akruis/cpython
that referenced
this pull request
May 27, 2021
Mention, that module "stackless" must be imported, to enable the extended pickling capabilities.
jaraco
pushed a commit
that referenced
this pull request
Dec 2, 2022
jaraco
added a commit
to jaraco/cpython
that referenced
this pull request
Feb 17, 2023
bpo-47142: Refine Traversable.
jaraco
added a commit
to jaraco/cpython
that referenced
this pull request
Feb 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On
rlcompleter.py, instead of usinggetattrdirectly, check if dealing with apropertywithinspect.getattr_static, so tab-completion doesn't trigger properties' getter execution.Trivia: here's a silly gist with some links while I was tracking down this thing.