bpo-27099: IDLE - Convert built-in extensions to regular features #2494
Conversation
adds fg color, bg color, font, and underline options for parens highlighting
|
@wohlganger, thanks for your PR! By analyzing the history of the files in this pull request, we identified @terryjreedy, @csabella and @kbkaiser to be potential reviewers. |
|
Per Terry J. Reedy recommendation, only highlighting style is changeable. |
wohlganger
changed the title
How did the change to the __doc__ of append not get fixed in the tests earlier?
Used incorrect / old python for testing.
Lib/idlelib/help.html
Outdated
| <li>RstripExtension</li> | ||
| </ul> | ||
| in the idlelib directory for further information. There are currently no default extensions.</p> | ||
|
|
There was a problem hiding this comment.
help.html is generated from Doc/library/idle.rst. So replace this edit with an edit of the latter. I believe it should be straightforward.
per terryjreedy request.
|
Charles, I cannot add commits to this issue, and a few others. Please follow the instructions at https://help.github.com/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork/#enabling-repository-maintainer-permissions-on-existing-pull-requests to make sure "Allow edits from maintainers." is checked for this and other IDLE issues. Please let me know what you find. If this permission is already granted, then I have some other problem with github. |
|
Checked "Allow edits". Thank you for pointing it out; I'll remember to check it in the future. |
|
It is on now. 'Allow edits' is supposed to be checked by default. If that changed, let me know and I will pass the information on to whoever can change it back. |
|
This may be complete enough, but I may decide to change the new mac bindings first, as I really do not like to leave IDLE in a can't-release regressed state after a commit. 'Code context' is visible on the option menu for Shell and Output Window but not operative. It should be gone (as before) or grayed out, but the current situation could be tolerated in a release. |
|
I ran test suite a couple of times, but now there are two failures to look at. FAIL: test_get_current_keyset (idlelib.idle_test.test_config.IdleConfTest) FAIL: test_click_help_source (idlelib.idle_test.test_query.HelpsourceGuiTest) |
|
I ran tests before changing Mac keys. I disabled test that depended on there being Alt keys in Mac or extension bindings. The other failure was due to sys.platform not being restored in first test. |
|
There are some regressions in the untested behavior of Config Dialog. I suspect they occurred before this patch, but I need to check before merging. |
|
By checking out master, I verified that the problems I found yesterday pre-existed this patch. The new one I found today required a fix to the new code. |
|
Thanks @wohlganger for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6. |
…es (pythonGH-2494) About 10 IDLE features were implemented as supposedly optional extensions. Their different behavior could be confusing or worse for users and not good for maintenance. Hence the conversion. The main difference for users is that user configurable key bindings for builtin features are now handled uniformly. Now, editing a binding in a keyset only affects its value in the keyset. All bindings are defined together in the system-specific default keysets in config- extensions.def. All custom keysets are saved as a whole in config- extension.cfg. All take effect as soon as one clicks Apply or Ok. The affected events are '<<force-open-completions>>', '<<expand-word>>', '<<force-open-calltip>>', '<<flash-paren>>', '<<format-paragraph>>', '<<run-module>>', '<<check-module>>', and '<<zoom-height>>'. Any (global) customizations made before 3.6.3 will not affect their keyset- specific customization after 3.6.3. and vice versa. Inital patch by Charles Wohlganger, revised by Terry Jan Reedy. (cherry picked from commit 58fc71c)
|
GH-3487 is a backport of this pull request to the 3.6 branch. |
…es (GH-2494) (#3487) About 10 IDLE features were implemented as supposedly optional extensions. Their different behavior could be confusing or worse for users and not good for maintenance. Hence the conversion. The main difference for users is that user configurable key bindings for builtin features are now handled uniformly. Now, editing a binding in a keyset only affects its value in the keyset. All bindings are defined together in the system-specific default keysets in config- extensions.def. All custom keysets are saved as a whole in config- extension.cfg. All take effect as soon as one clicks Apply or Ok. The affected events are '<<force-open-completions>>', '<<expand-word>>', '<<force-open-calltip>>', '<<flash-paren>>', '<<format-paragraph>>', '<<run-module>>', '<<check-module>>', and '<<zoom-height>>'. Any (global) customizations made before 3.6.3 will not affect their keyset- specific customization after 3.6.3. and vice versa. Inital patch by Charles Wohlganger, revised by Terry Jan Reedy. (cherry picked from commit 58fc71c)
https://bugs.python.org/issue27099