Skip to content

bpo-36540: Improve doc of function definition regarding positional-only arguments #25235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2021

Conversation

gousaiyang
Copy link
Contributor

@gousaiyang gousaiyang commented Apr 6, 2021

Better document the positional-only arguments feature in the "Function definitions" section.

https://bugs.python.org/issue36540

@pablogsal pablogsal merged commit 58d72ca into python:master Apr 7, 2021
@miss-islington
Copy link
Contributor

Thanks @gousaiyang for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@pablogsal
Copy link
Member

Thanks for the PR!

@miss-islington
Copy link
Contributor

Sorry @gousaiyang and @pablogsal, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 58d72cab89cf9652acc0bf0007aa20b2bcc98499 3.9

@pablogsal
Copy link
Member

@gousaiyang Could you do the backport manually by using cherry_picker 58d72cab89cf9652acc0bf0007aa20b2bcc98499 3.9 ?

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Apr 7, 2021
@bedevere-bot
Copy link

GH-25259 is a backport of this pull request to the 3.9 branch.

gousaiyang added a commit to gousaiyang/cpython that referenced this pull request Apr 7, 2021
…nal-only arguments (pythonGH-25235)

(cherry picked from commit 58d72ca)

Co-authored-by: Saiyang Gou <[email protected]>
gousaiyang added a commit to gousaiyang/cpython that referenced this pull request Apr 7, 2021
…nal-only arguments (pythonGH-25235)

(cherry picked from commit 58d72ca)

Co-authored-by: Saiyang Gou <[email protected]>
@gousaiyang gousaiyang deleted the funcdef-doc-posonly branch April 7, 2021 19:16
@gousaiyang
Copy link
Contributor Author

Done. And I also created #25260 to backport this to 3.8 (if needed).

pablogsal pushed a commit that referenced this pull request Apr 7, 2021
…nal-only arguments (GH-25235) (GH-25260)

(cherry picked from commit 58d72ca)

Co-authored-by: Saiyang Gou <[email protected]>
pablogsal pushed a commit that referenced this pull request Apr 7, 2021
…nal-only arguments (GH-25235) (GH-25259)

(cherry picked from commit 58d72ca)

Co-authored-by: Saiyang Gou <[email protected]>
@pablogsal
Copy link
Member

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants