bpo-43778: Fix Sphinx glossary_search extension #25286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create the _static/ directory if it doesn't exist. Add also constants for the static directory and the JSON filename.
ammaraskar
approved these changes
Apr 8, 2021
| @@ -15,6 +15,8 @@ | |||
|
|
|||
|
|
|||
| logger = logging.getLogger(__name__) | |||
| STATIC_DIR = '_static' | |||
| JSON = 'glossary.json' | |||
There was a problem hiding this comment.
Minor suggestion: JSON -> GLOSSARY_JSON
There was a problem hiding this comment.
Well, the extension is called "glossary_search", in the context of the extension, I don't think that it's worth it to repeat "glossary" ;-)
JulienPalard
reviewed
Apr 8, 2021
|
The extension works, I didn't see https://bugs.python.org/issue43778 bug in the 3 doc CI jobs. The Docs PR failure on Azure is unrelated: This issue was introduced https://bugs.python.org/issue43774 I'm aware of the issue and I will write a fix later. |
|
I merged my PR, thanks for the reviews @ammaraskar and @JulienPalard ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create the _static/ directory if it doesn't exist.
Add also constants for the static directory and the JSON filename.
https://bugs.python.org/issue43778