bpo-43785: Update bz2 document #25351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matrixise
reviewed
Apr 12, 2021
Doc/library/bz2.rst
Outdated
| @@ -140,6 +138,11 @@ All of the classes in this module may safely be accessed from multiple threads. | |||
|
|
|||
| The *compresslevel* parameter became keyword-only. | |||
|
|
|||
| .. versionchanged:: 3.10 | |||
| This class is now thread unsafe in the face of multiple simultaneous | |||
There was a problem hiding this comment.
Hi @methane , maybe you could remove the now, I am not sure it's really interesting.
Doc/whatsnew/3.10.rst
Outdated
| * :class:`BZ2File` performance is improved by removing internal ``RLock``. | ||
| This makes :class:`BZ2File` thread unsafe in the face of multiple simultaneous | ||
| readers or writers, just like its equivalent classes in :mod:`gzip` and | ||
| :mod:`lzma` have always been. (Contributed by inada Naoki in :issue:`43785`). |
There was a problem hiding this comment.
Just, I think you could use a upper case for your first name, Inada
|
There's also some wording at the top of https://docs.python.org/3/library/lzma.html that needs cleanup to not claim that bz2 is thread safe. |
matrixise
approved these changes
Apr 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue43785