Skip to content

gh-87980: Fix the error message for disallowed __weakref__ slots #25362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 1, 2023
Merged

gh-87980: Fix the error message for disallowed __weakref__ slots #25362

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f248c3
Fix the error message for disallowed __weakref__ slots
geryogam Apr 12, 2021
c9142d8
Merge branch 'main' into patch-23
kumaraditya303 Jan 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions Objects/typeobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2712,8 +2712,7 @@ type_new_visit_slots(type_new_ctx *ctx)
if (!ctx->may_add_weak || ctx->add_weak != 0) {
PyErr_SetString(PyExc_TypeError,
"__weakref__ slot disallowed: "
"either we already got one, "
"or __itemsize__ != 0");
"we already got one");
return -1;
}
ctx->add_weak++;
Expand Down