Skip to content

bpo-43928: Fix a typo in documentation #25568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

jeffreytse
Copy link
Contributor

@jeffreytse jeffreytse commented Apr 24, 2021

The boolean predicate was typo in documentation.

https://bugs.python.org/issue43928

The boolean predicate was typo in documentation.
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@jeffreytse

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@Fidget-Spinner
Copy link
Member

Fidget-Spinner commented Apr 24, 2021

Thanks for the PR! Unfortunately, I don't think this is a valid docs change. the current docs are correct as you can see here: https://docs.python.org/3/c-api/arg.html#other-objects

You can see that **p**\ redicate becomes predicate. The white space is escaped (\ ) so the **p** and redicate is merged into predicate in the rendered HTML.

The new change looks like this: ppredicate.

@rhettinger
Copy link
Contributor

I concur that this is invalid.

@rhettinger rhettinger closed this Apr 24, 2021
@jeffreytse
Copy link
Contributor Author

jeffreytse commented Apr 24, 2021

Oh, I see your key point, it's my mistake. But was it closed too fast? I still have the commits need to merge. I just found it was closed. 🙀

@jeffreytse
Copy link
Contributor Author

jeffreytse commented Apr 24, 2021

Hi, @rhettinger , could you reopen this PR? Or I just create a new PR for my other commits? Thanks and regards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants