bpo-43565: Document PyUnicode_KIND's return type as an unsigned int #25724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ammaraskar
force-pushed
the
document_pyunicode_kind
branch
2 times, most recently
from
e4a58d2 to
6f64245
Compare
ammaraskar
changed the title
vstinner
reviewed
Apr 29, 2021
ammaraskar
changed the title
ammaraskar
force-pushed
the
document_pyunicode_kind
branch
from
6f64245 to
da9c628
Compare
|
This PR is stale because it has been open for 30 days with no activity. |
encukou
added
needs backport to 3.9
encukou
approved these changes
Jul 27, 2021
|
@ammaraskar, could you merge in the main branch to let the updated checks run? |
|
Sure thing, closing and re-opening the PR also re-runs the checks. Let me go ahead and do that. |
|
Thanks @ammaraskar for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9. |
|
GH-27439 is a backport of this pull request to the 3.10 branch. |
|
GH-27440 is a backport of this pull request to the 3.9 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 29, 2021
…ythonGH-25724) (cherry picked from commit 47fd472) Co-authored-by: Ammar Askar <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 29, 2021
…ythonGH-25724) (cherry picked from commit 47fd472) Co-authored-by: Ammar Askar <[email protected]>
encukou
pushed a commit
that referenced
this pull request
Jul 29, 2021
…H-25724) (GH-27439) (cherry picked from commit 47fd472) Co-authored-by: Ammar Askar <[email protected]>
encukou
pushed a commit
that referenced
this pull request
Jul 29, 2021
…H-25724) (GH-27440) (cherry picked from commit 47fd472) Co-authored-by: Ammar Askar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like people are already using this enum within their code: https://github.com/search?p=1&q=enum+PyUnicode_Kind&type=Code
So as the bpo ticket suggests, we may as well document this type properly as an enum and correct the return type for
PyUnicode_KINDhttps://bugs.python.org/issue43565