-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
bpo-41963: document that ConfigParser strips off comments #26197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Slight wording change on configparser.py
Please note that comments get stripped off on reading
change to
Please note that comments get stripped off when reading
Also, to be consistent, is this about reading configuration files?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing review functionality. Sorry for duplicates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Slight grammar change and consistency on what is being read.
Co-authored-by: Laura Gutierrez Funderburk <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving changes.
Sorry @jugmac00 and @ambv, I had trouble checking out the |
…6197) Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com> Co-authored-by: Laura Gutierrez Funderburk <[email protected]> (cherry picked from commit 02ee819) Co-authored-by: Jürgen Gmach <[email protected]>
GH-26213 is a backport of this pull request to the 3.9 branch. |
…honGH-26197) Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com> Co-authored-by: Laura Gutierrez Funderburk <[email protected]> (cherry picked from commit 02ee819) Co-authored-by: Jürgen Gmach <[email protected]>
GH-26214 is a backport of this pull request to the 3.10 branch. |
…H-26213) Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com> Co-authored-by: Laura Gutierrez Funderburk <[email protected]> Co-authored-by: Jürgen Gmach <[email protected]> (cherry picked from commit 02ee819)
…26197) (GH-26214) Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com> Co-authored-by: Laura Gutierrez Funderburk <[email protected]> Co-authored-by: Jürgen Gmach <[email protected]> (cherry picked from commit 02ee819)
... when reading a configuration file.
https://bugs.python.org/issue41963