Skip to content

bpo-41963: document that ConfigParser strips off comments #26197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 18, 2021

Conversation

jugmac00
Copy link
Contributor

@jugmac00 jugmac00 commented May 17, 2021

... when reading a configuration file.

https://bugs.python.org/issue41963

@ghost
Copy link

ghost commented May 17, 2021

Reviewing

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slight wording change on configparser.py

Please note that comments get stripped off on reading

change to

Please note that comments get stripped off when reading

Also, to be consistent, is this about reading configuration files?

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing review functionality. Sorry for duplicates.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slight grammar change and consistency on what is being read.

Co-authored-by: Laura Gutierrez Funderburk <[email protected]>
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving changes.

@ambv ambv added needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes labels May 18, 2021
@ambv ambv merged commit 02ee819 into python:main May 18, 2021
@miss-islington
Copy link
Contributor

Thanks @jugmac00 for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @jugmac00 and @ambv, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 02ee8191263848f8c8999f72286148946b83e5c9 3.10

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 18, 2021
…6197)

Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Laura Gutierrez Funderburk <[email protected]>
(cherry picked from commit 02ee819)

Co-authored-by: Jürgen Gmach <[email protected]>
@bedevere-bot
Copy link

GH-26213 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label May 18, 2021
@jugmac00 jugmac00 deleted the bpo-41963 branch May 18, 2021 16:13
ambv pushed a commit to ambv/cpython that referenced this pull request May 18, 2021
…honGH-26197)

Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Laura Gutierrez Funderburk <[email protected]>
(cherry picked from commit 02ee819)

Co-authored-by: Jürgen Gmach <[email protected]>
@bedevere-bot
Copy link

GH-26214 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label May 18, 2021
ambv pushed a commit that referenced this pull request May 18, 2021
…H-26213)

Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Laura Gutierrez Funderburk <[email protected]>
Co-authored-by: Jürgen Gmach <[email protected]>

(cherry picked from commit 02ee819)
ambv added a commit that referenced this pull request May 18, 2021
…26197) (GH-26214)

Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Laura Gutierrez Funderburk <[email protected]>
Co-authored-by: Jürgen Gmach <[email protected]>

(cherry picked from commit 02ee819)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants