Skip to content

[3.6] bpo-30779: IDLE -- Factor ConfigChanges class from configdialog… #2625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 7, 2017
Merged

[3.6] bpo-30779: IDLE -- Factor ConfigChanges class from configdialog… #2625

merged 1 commit into from
Jul 7, 2017

Conversation

terryjreedy
Copy link
Member

…, put in config; test. (GH-2612)

  • In config, put dump test code in a function; run it and unittest in 'if name == 'main'.
  • Add class config.ConfigChanges based on changes_class_v4.py on bpo issue.
  • Add class test_config.ChangesTest, partly based on configdialog_tests_v1.py on bpo issue.
  • Revise configdialog to use ConfigChanges, mostly as specified in tracker msg297804.
  • Revise test_configdialog to match configdialog changes. All tests pass in both files.
  • Remove configdialog functions unused or moved to ConfigChanges.
    Cheryl Sabella contributed parts of the patch.
    (cherry picked from commit 349abd9)

@terryjreedy
[3.6] bpo-30779: IDLE -- Factor ConfigChanges class from configdialog…
75c7e6e 
…, put in config; test. (pythonGH-2612)

* In config, put dump test code in a function; run it and unittest in 'if __name__ == '__main__'.
* Add class config.ConfigChanges based on changes_class_v4.py on bpo issue.
* Add class test_config.ChangesTest, partly based on configdialog_tests_v1.py on bpo issue.
* Revise configdialog to use ConfigChanges, mostly as specified in tracker msg297804.
* Revise test_configdialog to match configdialog changes.  All tests pass in both files.
* Remove configdialog functions unused or moved to ConfigChanges.
Cheryl Sabella contributed parts of the patch.
(cherry picked from commit 349abd9)
@terryjreedy terryjreedy merged commit edc0342 into python:3.6 Jul 7, 2017
@terryjreedy terryjreedy deleted the backport-349abd9-3.6 branch July 7, 2017 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@terryjreedy @the-knights-who-say-ni