Skip to content

Fix typo for configure.ac #26305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 21, 2021
Merged

Fix typo for configure.ac #26305

merged 1 commit into from
May 21, 2021

Conversation

corona10
Copy link
Member

@corona10 corona10 commented May 21, 2021 •
edited
Loading

From #26078

@corona10 corona10 requested a review from ned-deily May 21, 2021 22:34
@corona10 corona10 changed the title Fix typo for configure.ac [WIP] Fix typo for configure.ac May 21, 2021
@corona10 corona10 force-pushed the configure_typo branch 2 times, most recently from bf2c4f0 to ffe5d41 Compare May 21, 2021 22:50
ned-deily
ned-deily requested changes May 21, 2021
View reviewed changes
Copy link
Member

@ned-deily ned-deily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like there is a difference between the autoconf version you are using and the one last used to merge. As noted in configure.ac, we are using 2.69 but there are newer versions out there. Since this is truly a one-line change, I suggest you forget about trying autoreconf for this and just make that change manually :)

@bedevere-bot
Copy link

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@corona10
Copy link
Member Author

I suggest you forget about trying autoreconf for this and just make that change manually :)

Got it

@corona10 corona10 changed the title [WIP] Fix typo for configure.ac Fix typo for configure.ac May 21, 2021
@corona10
Copy link
Member Author

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@ned-deily: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from ned-deily May 21, 2021 22:56
ned-deily
ned-deily approved these changes May 21, 2021
View reviewed changes
Copy link
Member

@ned-deily ned-deily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Sorry about all the churn.

@corona10
Copy link
Member Author

Thank you @ned-deily
And sorry about my uncareful mistake.

@corona10 corona10 merged commit a9e4361 into python:main May 21, 2021
@corona10 corona10 deleted the configure_typo branch May 21, 2021 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willingc willingc willingc approved these changes

@ned-deily ned-deily ned-deily approved these changes

Assignees
No one assigned
Labels
skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@corona10 @bedevere-bot @willingc @ned-deily @the-knights-who-say-ni