Skip to content

bpo-41611: IDLE: fix freezing on completion on macOS #26400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

taleinat
Copy link
Contributor

@taleinat taleinat commented May 27, 2021

@taleinat
Copy link
Contributor Author

CC @E-Paine, @csabella, if one of you can confirm this on macOS that would be helpful.

Signed-off-by: Tal Einat <[email protected]>
@E-Paine
Copy link
Contributor

E-Paine commented May 27, 2021

Fix works on my system.

@taleinat
Copy link
Contributor Author

Fix works on my system.

Thanks @E-Paine!

@taleinat taleinat added needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes type-bug An unexpected behavior, bug, or error OS-mac labels May 27, 2021
@E-Paine
Copy link
Contributor

E-Paine commented May 27, 2021

Can we add a test for this, to ensure it doesn't occur in the future? Edit: is that possible?

@taleinat
Copy link
Contributor Author

Can we add a test for this, to ensure it doesn't occur in the future? Edit: is that possible?

Possible but hard, and we don't have the infrastructure for it yet.

We'd need a way to run IDLE in a sub-process, send events, inspect what happens, and close it cleanly.

We could add a specific h-test for this, but IMO that wouldn't be worth it.

@ned-deily
Copy link
Member

LGTM, too. It may still be possible to get this into the delayed 3.10.0b2 if it is merged to 3.10 quickly.

@taleinat
Copy link
Contributor Author

It may still be possible to get this into the delayed 3.10.0b2 if it is merged to 3.10 quickly.

Ooh yes, let's! Merging now.

@taleinat taleinat merged commit abc4bd5 into python:main May 27, 2021
@miss-islington
Copy link
Contributor

Thanks @taleinat for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 27, 2021
@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label May 27, 2021
@bedevere-bot
Copy link

GH-26401 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 27, 2021
@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label May 27, 2021
@bedevere-bot
Copy link

GH-26402 is a backport of this pull request to the 3.9 branch.

@taleinat taleinat deleted the bpo-issue41611/IDLE-macos-fix-freeze-on-completion branch May 27, 2021 14:32
miss-islington added a commit that referenced this pull request May 27, 2021
miss-islington added a commit that referenced this pull request May 27, 2021
@terryjreedy
Copy link
Member

I verified the fix on installed .0b1 on Mac by #ing the line. Both Tab and .[popup] work great. Thank you Tal and others for fixing this and getting it, I hope, into .0b2!!!

The last line of autocomplete_w.py: # TODO: autocomplete/w htest here. I added this, and now put it on my classified list of issues to work on. It is definitely worthwhile because part of the test, besides working, is 'Does this widget look OK?'. This must be about the last visible widget that is not h-tested.

@E-Paine If you want to try this, use the calltip h-test as a model. (and that one should be extended if possible to test force-open).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS-mac type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants