bpo-41299: fix 16ms jitter in Windows threading timeouts #26568
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zooba
added
needs backport to 3.9
|
Thanks @lunixbochs for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9. |
|
Sorry @lunixbochs and @zooba, I had trouble checking out the |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 7, 2021
… precision time source (pythonGH-26568) (cherry picked from commit 449e6f0) Co-authored-by: Ryan Hileman <[email protected]>
|
GH-26579 is a backport of this pull request to the 3.9 branch. |
zooba
added
needs backport to 3.10
|
Thanks @lunixbochs for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10. |
|
GH-26580 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 7, 2021
… precision time source (pythonGH-26568) (cherry picked from commit 449e6f0) Co-authored-by: Ryan Hileman <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Jun 11, 2021
… precision time source (GH-26568) (cherry picked from commit 449e6f0) Co-authored-by: Ryan Hileman <[email protected]>
pablogsal
pushed a commit
that referenced
this pull request
Jun 20, 2021
… precision time source (GH-26568) (GH-26580) (cherry picked from commit 449e6f0) Co-authored-by: Ryan Hileman <[email protected]> Co-authored-by: Ryan Hileman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetTickCount64() is quantized to 16ms, which makes it unsuitable for measuring short timeouts.
QueryPerformanceCounter() has been guaranteed to work since Windows XP. It should only return an error if you pass in an unaligned pointer, which should only happen if your compiler doesn't align the stack.
https://bugs.python.org/issue41299