[3.10] bpo-44498: Issue a deprecation warning on asynchat, asyncore and smtpd import (GH-26882) #26904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d import (pythonGH-26882) * Issue a deprecation warning on smtpd import * Also issue DeprecationWarnings for asynchat and asyncore * Fix some tests * test___all__ requires the word 'module' or 'package' in the deprecation warning text, so add those to smtpd, asynchat, and asyncore. * In test_support, use pprint now instead of asyncore as the landmark. * Add What's New * Use ..deprecated:: * Use ..deprecated:: * Update Lib/smtpd.py Co-authored-by: Miro Hrončok <[email protected]> * Update Doc/library/smtpd.rst Co-authored-by: Miro Hrončok <[email protected]> * Import async{hat,ore} after the DeprecationWarning for this module Co-authored-by: Miro Hrončok <[email protected]> (cherry picked from commit 8488b85) Co-authored-by: Barry Warsaw <[email protected]>
|
@warsaw: Status check is done, and it's a success ✅ . |
|
@warsaw: Status check is done, and it's a success ✅ . |
2 similar comments
|
@warsaw: Status check is done, and it's a success ✅ . |
|
@warsaw: Status check is done, and it's a success ✅ . |
warsaw
approved these changes
Jun 24, 2021
|
@miss-islington: Status check is done, and it's a success ✅ . |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue a deprecation warning on smtpd import
Also issue DeprecationWarnings for asynchat and asyncore
Fix some tests
test___all__ requires the word 'module' or 'package' in the deprecation
warning text, so add those to smtpd, asynchat, and asyncore.
In test_support, use pprint now instead of asyncore as the landmark.
Add What's New
Use ..deprecated::
Use ..deprecated::
Update Lib/smtpd.py
Co-authored-by: Miro Hrončok [email protected]
Co-authored-by: Miro Hrončok [email protected]
Co-authored-by: Miro Hrončok [email protected]
(cherry picked from commit 8488b85)
Co-authored-by: Barry Warsaw [email protected]
https://bugs.python.org/issue44498
Automerge-Triggered-By: GH:warsaw