Skip to content

Fix typo with missing colon in try statement #26911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 28, 2021
Merged

Fix typo with missing colon in try statement #26911

merged 1 commit into from
Jun 28, 2021

Conversation

rodrigogiraoserrao
Copy link
Contributor

The try statement was missing a colon and therefore was not exemplifying the correct SyntaxError.

As per the Python Developer's Guide, 6.3 Proofreading, this PR is not linked to any bpo issue.

The `try` statement was missing a colon and therefore was not exemplifying the correct `SyntaxError`.
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@RojerGS

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added the docs Documentation in the Doc dir label Jun 26, 2021
@iritkatriel
Copy link
Member

Thanks @RogerGs. We can merge a typo fix without you signing the CLA if you don't want to, but ideally you should sign it so that you can make more substantial contributions.

@rodrigogiraoserrao
Copy link
Contributor Author

rodrigogiraoserrao commented Jun 28, 2021

@iritkatriel I made the PR and signed the CLA during the weekend, so it took some time to process. This was a light first PR. Let's see if I can make more significant contributions 😄

@iritkatriel iritkatriel merged commit dcb1cae into python:main Jun 28, 2021
@miss-islington
Copy link
Contributor

Thanks @RojerGS for the PR, and @iritkatriel for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-26940 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jun 28, 2021
@iritkatriel
Copy link
Member

@RojerGS Welcome to CPython!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 28, 2021
The `try` statement was missing a colon and therefore was not exemplifying the correct `SyntaxError`.
(cherry picked from commit dcb1cae)

Co-authored-by: Rodrigo Girão Serrão <[email protected]>
@rodrigogiraoserrao rodrigogiraoserrao deleted the patch-1 branch June 29, 2021 06:17
iritkatriel pushed a commit that referenced this pull request Jun 29, 2021
The `try` statement was missing a colon and therefore was not exemplifying the correct `SyntaxError`.
(cherry picked from commit dcb1cae)

Co-authored-by: Rodrigo Girão Serrão <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants