bpo-44635: Convert None to NoneType in the union type constructor #27136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serhiy-storchaka
added
needs backport to 3.9
| self.assertEqual((int | (str | list)).__args__, (int, str, list)) | ||
| self.assertEqual((int | None).__args__, (int, type(None))) | ||
| self.assertEqual((int | type(None)).__args__, (int, type(None))) | ||
|
|
There was a problem hiding this comment.
I recommend one more simple test to test equality of two unions.
Suggested change
| self.assertEqual(int | type(None), int | None) | |
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10. |
|
Sorry @serhiy-storchaka, I had trouble checking out the |
Fidget-Spinner
pushed a commit
to Fidget-Spinner/cpython
that referenced
this pull request
Jul 14, 2021
|
GH-27141 is a backport of this pull request to the 3.10 branch. |
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this pull request
Jul 14, 2021
…tor (pythonGH-27136). (cherry picked from commit b81cac0) Co-authored-by: Serhiy Storchaka <[email protected]>
serhiy-storchaka
added a commit
that referenced
this pull request
Jul 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue44635