Skip to content

bpo-44639: fix typo in sqlite.rst (transation => transaction) #27145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2021

Conversation

jdevries3133
Copy link
Contributor

@jdevries3133 jdevries3133 commented Jul 14, 2021

To my understanding, this is supposed to say "transaction".

See the relevant source:

/*[clinic input]
_sqlite3.Connection.executescript as pysqlite_connection_executescript
sql_script as script_obj: object
/
Executes a multiple SQL statements at once. Non-standard.
[clinic start generated code]*/
static PyObject *
pysqlite_connection_executescript(pysqlite_Connection *self,
PyObject *script_obj)
/*[clinic end generated code: output=4c4f9d77aa0ae37d input=c0b14695aa6c81d9]*/
{
_Py_IDENTIFIER(executescript);
PyObject* cursor = 0;
PyObject* result = 0;
cursor = _PyObject_CallMethodIdNoArgs((PyObject*)self, &PyId_cursor);
if (!cursor) {
goto error;
}
result = _PyObject_CallMethodIdObjArgs(cursor, &PyId_executescript,
script_obj, NULL);
if (!result) {
Py_CLEAR(cursor);
}
error:
Py_XDECREF(result);
return cursor;
}

https://bugs.python.org/issue44639

Automerge-Triggered-By: GH:pablogsal

Copy link
Contributor

@felixxm felixxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jdevries3133 Thanks 👍

@erlend-aasland
Copy link
Contributor

cc. @pablogsal

@miss-islington
Copy link
Contributor

Thanks @jdevries3133 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-27148 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jul 14, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 14, 2021
@bedevere-bot
Copy link

GH-27149 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Jul 14, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 14, 2021
pablogsal pushed a commit that referenced this pull request Jul 14, 2021
…) (GH-27148)

To my understanding, this is supposed to say "transaction".

See the relevant source:

https://github.com/python/cpython/blob/a158b20019b50e3ece6e4743ec4e6ae8d818b690/Modules/_sqlite/connection.cGH-L1434-L1467
(cherry picked from commit 1ca27f2)

Co-authored-by: Jack DeVries <[email protected]>

Co-authored-by: Jack DeVries <[email protected]>
pablogsal pushed a commit that referenced this pull request Jul 14, 2021
…) (GH-27149)

To my understanding, this is supposed to say "transaction".

See the relevant source:

https://github.com/python/cpython/blob/a158b20019b50e3ece6e4743ec4e6ae8d818b690/Modules/_sqlite/connection.cGH-L1434-L1467
(cherry picked from commit 1ca27f2)

Co-authored-by: Jack DeVries <[email protected]>

Co-authored-by: Jack DeVries <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants