Skip to content

Remove legacy opcache structs #27164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 16, 2021
Merged

Remove legacy opcache structs #27164

merged 2 commits into from
Jul 16, 2021

Conversation

Fidget-Spinner
Copy link
Member

No description provided.

@Fidget-Spinner Fidget-Spinner changed the title Remove legacy opcache Remove legacy opcache structs Jul 15, 2021
corona10
corona10 requested changes Jul 16, 2021
View reviewed changes
Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cpython/Objects/codeobject.c

Line 7 in 4823d9a

#include "pycore_code.h" // _PyOpcache 

// _PyOpcache  --> _PyCodeConstructor ?

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@Fidget-Spinner
Copy link
Member Author

cpython/Objects/codeobject.c

Line 7 in 4823d9a

#include "pycore_code.h" // _PyOpcache 

// _PyOpcache  --> _PyCodeConstructor ?

You're right. Thanks for the catch.

@corona10 corona10 merged commit e9cd47d into python:main Jul 16, 2021
@Fidget-Spinner Fidget-Spinner deleted the remove_old_opcache branch July 16, 2021 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corona10 corona10 corona10 approved these changes

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees
No one assigned
Labels
skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Fidget-Spinner @bedevere-bot @corona10 @the-knights-who-say-ni