Skip to content

Fix small typos in introduction and datastructures of tutorial #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 25, 2017
Merged

Fix small typos in introduction and datastructures of tutorial #272

merged 2 commits into from
Feb 25, 2017

Conversation

DimitrisJim
Copy link
Contributor

A couple of small issues:

  • Remove reference to Unicode string in introduction.
  • Fix description of list.extend to mention iterable (and not make it look like only lists are allowed)
  • "subsequence of x" should be "subsequence of the list"

@wm75
Copy link

wm75 commented Feb 24, 2017

Why not change the name of the argument to list.extend from L to i or iterable then?

@DimitrisJim
Copy link
Contributor Author

DimitrisJim commented Feb 24, 2017 •
edited
Loading

The iterable idea sounds like a good idea to me, it would also match the output of help(list.extend). @berkerpeksag should I tweak the signature to match .extends source doc?

@berkerpeksag
Copy link
Member

Changing the signature from L to iterable sounds good to me too.

@DimitrisJim
Copy link
Contributor Author

Done, thanks for the suggestion, @wm75!

@Mariatta Mariatta merged commit 53c1892 into python:master Feb 25, 2017
Mariatta pushed a commit to Mariatta/cpython that referenced this pull request Feb 25, 2017
@DimitrisJim @Mariatta
Fix small typos in introduction and datastructures of tutorial (pytho…
12ae3cc 
…nGH-272)

* Fix small typos in introduction and datastructures
* Use iterable instead of L in the doc for list.extend

(cherry picked from commit 53c1892)
Mariatta pushed a commit to Mariatta/cpython that referenced this pull request Feb 25, 2017
@DimitrisJim @Mariatta
Fix small typos in introduction and datastructures of tutorial (pytho…
56f299f 
…nGH-272)

* Fix small typos in introduction and datastructures
* Use iterable instead of L in the doc for list.extend

(cherry picked from commit 53c1892)
@Mariatta Mariatta mentioned this pull request Feb 25, 2017
Merged
Mariatta added a commit that referenced this pull request Feb 26, 2017
@Mariatta
Fix small typos in introduction and datastructures of tutorial (GH-272)…
b002328 
… (GH-297)

(cherry picked from commit 53c1892)
Mariatta added a commit that referenced this pull request Feb 26, 2017
@Mariatta
[3.5] Fix small typos in introduction and datastructures of tutorial (G…
4c78463 
…H-272) (GH-299)

(cherry picked from commit 5bd5b9d)
(cherry picked from commit 8c5e190)
(cherry picked from commit 53c1892)
@DimitrisJim DimitrisJim deleted the fix_typos branch March 27, 2017 20:56
akruis pushed a commit to akruis/cpython that referenced this pull request Jun 15, 2021
Stackless issue python#272: convert macro HANDLE_UNWINDING to a function
b325b6e 
Convert most of the macro HANDLE_UNWINDING in ceval.c to a static inline
function handle_inline(). This improves maintainability.
akruis pushed a commit to akruis/cpython that referenced this pull request Jun 18, 2021
Stackless issue python#272: convert macro HANDLE_UNWINDING to a function
f730a4e 
Add some assertions
akruis added a commit to akruis/cpython that referenced this pull request Jun 20, 2021
@akruis
Stackless issue python#272: convert macro HANDLE_UNWINDING to a function
bf0c174 
Convert most of the macro HANDLE_UNWINDING in ceval.c to a static inline
function handle_inline(). This improves maintainability.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berkerpeksag berkerpeksag berkerpeksag approved these changes

@Mariatta Mariatta Mariatta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@DimitrisJim @wm75 @berkerpeksag @Mariatta @the-knights-who-say-ni