Skip to content

[3.10] bpo-44490: Improve typing module compatibility with types.Union (GH-27048) #27220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[3.10] bpo-44490: Improve typing module compatibility with types.Union (GH-27048) #27220

wants to merge 1 commit into from

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jul 18, 2021 •
edited by bedevere-bot
Loading

(cherry picked from commit bf89ff9)

Co-authored-by: Yurii Karabas [email protected]

https://bugs.python.org/issue44490

@bedevere-bot bedevere-bot mentioned this pull request Jul 18, 2021
Merged
@miss-islington
Copy link
Contributor Author

Sorry, I can't merge this PR. Reason: 3 of 5 required status checks are expected..

@gvanrossum gvanrossum changed the title [3.10] bpo-44490: Improve typing module compatibility with types.Union (GH-27048) bpo-44490: [3.10] Improve typing module compatibility with types.Union (GH-27048) Jul 18, 2021
@gvanrossum gvanrossum changed the title bpo-44490: [3.10] Improve typing module compatibility with types.Union (GH-27048) bpo-44490 [3.10]: Improve typing module compatibility with types.Union (GH-27048) Jul 18, 2021
@gvanrossum gvanrossum changed the title bpo-44490 [3.10]: Improve typing module compatibility with types.Union (GH-27048) [3.10] bpo-44490: Improve typing module compatibility with types.Union (GH-27048) Jul 18, 2021
@miss-islington
Copy link
Contributor Author

@uriyyo and @gvanrossum: Status check is done, and it's a success ✅ .

1 similar comment
@miss-islington
Copy link
Contributor Author

@uriyyo and @gvanrossum: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

Sorry, I can't merge this PR. Reason: Required status check "bedevere/news" is expected..

1 similar comment
@miss-islington
Copy link
Contributor Author

Sorry, I can't merge this PR. Reason: Required status check "bedevere/news" is expected..

@gvanrossum
Copy link
Member

Sorry for the spurious title changes. But I fear the news check is stuck?

@Fidget-Spinner
Copy link
Member

Sorry for the spurious title changes. But I fear the news check is stuck?

Yeah I gave up on this PR and opened another one at GH-27222 to rerun that check.

@miss-islington miss-islington deleted the backport-bf89ff9-3.10 branch July 18, 2021 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

Assignees
No one assigned
Labels
awaiting merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@miss-islington @gvanrossum @Fidget-Spinner @the-knights-who-say-ni @bedevere-bot @uriyyo