bpo-44752: refactor part of rlcompleter.Completer.attr_matches #27433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will require resolving the conflict with the currently landed GH-27401, @jdevries3133. |
|
@ambv merged! |
|
The ASAN failure is a re-run timeout. |
ambv
added
needs backport to 3.9
|
Thanks @jdevries3133 for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9. |
|
Thanks @jdevries3133 for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10. |
|
GH-27446 is a backport of this pull request to the 3.9 branch. |
|
GH-27447 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 29, 2021
…nGH-27433) (cherry picked from commit 6741794) Co-authored-by: Jack DeVries <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 29, 2021
…nGH-27433) (cherry picked from commit 6741794) Co-authored-by: Jack DeVries <[email protected]>
ambv
pushed a commit
that referenced
this pull request
Jul 29, 2021
) (GH-27447) (cherry picked from commit 6741794) Co-authored-by: Jack DeVries <[email protected]>
ambv
pushed a commit
that referenced
this pull request
Jul 29, 2021
) (GH-27446) (cherry picked from commit 6741794) Co-authored-by: Jack DeVries <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the discussion about this change here:
#27401 (comment)
https://bugs.python.org/issue44752