Skip to content

bpo-26184: import.rst: Add versionchanged note #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2017
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions Doc/reference/import.rst
Original file line number Diff line number Diff line change
Expand Up @@ -464,8 +464,11 @@ import machinery will create the new module itself.

.. versionchanged:: 3.5
A :exc:`DeprecationWarning` is raised when ``exec_module()`` is defined but
``create_module()`` is not. Starting in Python 3.6 it will be an error to not
define ``create_module()`` on a loader attached to a ModuleSpec.
``create_module()`` is not.

.. versionchanged:: 3.6
An :exc:`ImportError` is raised when ``exec_module()`` is defined but
``create_module`` is not.
Copy link
Member

@berkerpeksag berkerpeksag Feb 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess create_module should be create_module() here since the latter form is also used in the first versionchanged note.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this, @berkerpeksag! I fixed it in GH-325


Submodules
----------
Expand Down