bpo-45182: Fix incorrect use of requires_zlib in test_bdist_rpm #28305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is a decorator factory and should be always followed by "()".
serhiy-storchaka
added
tests
|
🤖 New build scheduled with the buildbot fleet by @serhiy-storchaka for commit f25763d 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
bedevere-bot
removed
the
🔨 test-with-buildbots
erlend-aasland
approved these changes
Sep 13, 2021
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 13, 2021
…onGH-28305) It is a decorator factory and should be always followed by "()". (cherry picked from commit 9260e67) Co-authored-by: Serhiy Storchaka <[email protected]>
|
GH-28308 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 13, 2021
…onGH-28305) It is a decorator factory and should be always followed by "()". (cherry picked from commit 9260e67) Co-authored-by: Serhiy Storchaka <[email protected]>
|
GH-28309 is a backport of this pull request to the 3.9 branch. |
miss-islington
added a commit
that referenced
this pull request
Sep 13, 2021
…8305) It is a decorator factory and should be always followed by "()". (cherry picked from commit 9260e67) Co-authored-by: Serhiy Storchaka <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Sep 13, 2021
…8305) It is a decorator factory and should be always followed by "()". (cherry picked from commit 9260e67) Co-authored-by: Serhiy Storchaka <[email protected]>
lazka
added a commit
to lazka/distutils
that referenced
this pull request
Dec 27, 2021
It was passing the test function itself as an argument, skipping the test always. See python/cpython#28305 for the same fix in CPython.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is a decorator factory and should be always followed by "()".
https://bugs.python.org/issue45182