bpo-45183: don't raise an exception when calling zipimport.zipimporter.find_spec() when the zip file is missing and the internal cache has been reset #28435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…) when a zip file is missing and the internal cache has been reset
brettcannon
requested review from
encukou,
ericsnowcurrently,
ncoghlan and
warsaw
as code owners
brettcannon
changed the title
brettcannon
changed the title
|
Thanks @brettcannon for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10. |
|
GH-28437 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 17, 2021
…r.find_spec() when the zip file is missing and the internal cache has been reset (pythonGH-28435) This can occur when the zip file gets deleted, you call zipimport.zipimporter.invalidate_cache(), and then try to use zipimport.zipimporter.find_spec() (i.e. you left the zip file path on sys.path). (cherry picked from commit 209b703) Co-authored-by: Brett Cannon <[email protected]>
brettcannon
added a commit
to brettcannon/cpython
that referenced
this pull request
Sep 18, 2021
…importer.find_spec() when the zip file is missing and the internal cache has been reset (pythonGH-28435) This can occur when the zip file gets deleted, you call zipimport.zipimporter.invalidate_cache(), and then try to use zipimport.zipimporter.find_spec() (i.e. you left the zip file path on sys.path). (cherry picked from commit 209b703) Co-authored-by: Brett Cannon <[email protected]>
brettcannon
added a commit
that referenced
this pull request
Sep 18, 2021
…importer.find_spec() when the zip file is missing and the internal cache has been reset (GH-28435) (#28438) This can occur when the zip file gets deleted, you call zipimport.zipimporter.invalidate_cache(), and then try to use zipimport.zipimporter.find_spec() (i.e. you left the zip file path on sys.path). (cherry picked from commit 209b703) Co-authored-by: Brett Cannon <[email protected]>
niyas-sait
pushed a commit
to niyas-sait/cpython
that referenced
this pull request
Sep 21, 2021
…r.find_spec() when the zip file is missing and the internal cache has been reset (pythonGH-28435) This can occur when the zip file gets deleted, you call zipimport.zipimporter.invalidate_cache(), and then try to use zipimport.zipimporter.find_spec() (i.e. you left the zip file path on sys.path).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can occur when the zip file gets deleted, you call zipimport.zipimporter.invalidate_cache(), and then try to use zipimport.zipimporter.find_spec() (i.e. you left the zip file path on sys.path).
https://bugs.python.org/issue45183
Automerge-Triggered-By: GH:brettcannon