Clean up initialization __class_getitem__ with Py_GenericAlias. #28450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cast to PyCFunction is redundant. Overuse of redundant casts can hide actual bugs.
serhiy-storchaka
requested review from
1st1,
ethanfurman,
markshannon,
methane and
rhettinger
as code owners
|
Should the example in the docs change too? https://docs.python.org/3/c-api/typehints.html |
methane
approved these changes
Sep 19, 2021
|
Good catch @Fidget-Spinner! |
niyas-sait
pushed a commit
to niyas-sait/cpython
that referenced
this pull request
Sep 21, 2021
…onGH-28450) The cast to PyCFunction is redundant. Overuse of redundant casts can hide actual bugs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cast to PyCFunction is redundant. Overuse of redundant casts
can hide actual bugs.