Skip to content

bpo-41299: Mark private thread_nt.h functions as static #28553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 24, 2021
Merged

bpo-41299: Mark private thread_nt.h functions as static #28553

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions Python/thread_nt.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ typedef struct _NRMUTEX
} NRMUTEX;
typedef NRMUTEX *PNRMUTEX;

PNRMUTEX
AllocNonRecursiveMutex()
static PNRMUTEX
AllocNonRecursiveMutex(void)
{
PNRMUTEX m = (PNRMUTEX)PyMem_RawMalloc(sizeof(NRMUTEX));
if (!m)
Expand All @@ -51,7 +51,7 @@ AllocNonRecursiveMutex()
return NULL;
}

VOID
static VOID
FreeNonRecursiveMutex(PNRMUTEX mutex)
{
if (mutex) {
Expand All @@ -61,7 +61,7 @@ FreeNonRecursiveMutex(PNRMUTEX mutex)
}
}

DWORD
static DWORD
EnterNonRecursiveMutex(PNRMUTEX mutex, DWORD milliseconds)
{
DWORD result = WAIT_OBJECT_0;
Expand Down Expand Up @@ -104,7 +104,7 @@ EnterNonRecursiveMutex(PNRMUTEX mutex, DWORD milliseconds)
return result;
}

BOOL
static BOOL
LeaveNonRecursiveMutex(PNRMUTEX mutex)
{
BOOL result;
Expand All @@ -122,26 +122,26 @@ LeaveNonRecursiveMutex(PNRMUTEX mutex)
/* NR-locks based on a kernel mutex */
#define PNRMUTEX HANDLE

PNRMUTEX
AllocNonRecursiveMutex()
static PNRMUTEX
AllocNonRecursiveMutex(void)
{
return CreateSemaphore(NULL, 1, 1, NULL);
}

VOID
static VOID
FreeNonRecursiveMutex(PNRMUTEX mutex)
{
/* No in-use check */
CloseHandle(mutex);
}

DWORD
static DWORD
EnterNonRecursiveMutex(PNRMUTEX mutex, DWORD milliseconds)
{
return WaitForSingleObjectEx(mutex, milliseconds, FALSE);
}

BOOL
static BOOL
LeaveNonRecursiveMutex(PNRMUTEX mutex)
{
return ReleaseSemaphore(mutex, 1, NULL);
Expand Down