Skip to content

bpo-24241: Add dedicated webbrowser.register test case #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2017
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 53 additions & 0 deletions Lib/test/test_webbrowser.py
Original file line number Diff line number Diff line change
Expand Up @@ -213,5 +213,58 @@ def test_open_new_tab(self):
arguments=['openURL({},new-tab)'.format(URL)])


class BrowserRegistrationTest(unittest.TestCase):

def setUp(self):
# Ensure we don't alter the real registered browser details
self._saved_tryorder = webbrowser._tryorder
webbrowser._tryorder = []
self._saved_browsers = webbrowser._browsers
webbrowser._browsers = {}

def tearDown(self):
webbrowser._tryorder = self._saved_tryorder
webbrowser._browsers = self._saved_browsers

def _check_registration(self, preferred):
class ExampleBrowser:
pass

expected_tryorder = []
expected_browsers = {}

self.assertEqual(webbrowser._tryorder, expected_tryorder)
self.assertEqual(webbrowser._browsers, expected_browsers)

webbrowser.register('Example1', ExampleBrowser)
expected_tryorder = ['Example1']
expected_browsers['example1'] = [ExampleBrowser, None]
self.assertEqual(webbrowser._tryorder, expected_tryorder)
self.assertEqual(webbrowser._browsers, expected_browsers)

instance = ExampleBrowser()
if preferred is not None:
webbrowser.register('example2', ExampleBrowser, instance,
preferred=preferred)
else:
webbrowser.register('example2', ExampleBrowser, instance)
if preferred:
expected_tryorder = ['example2', 'Example1']
else:
expected_tryorder = ['Example1', 'example2']
expected_browsers['example2'] = [ExampleBrowser, instance]
self.assertEqual(webbrowser._tryorder, expected_tryorder)
self.assertEqual(webbrowser._browsers, expected_browsers)

def test_register(self):
self._check_registration(preferred=False)

def test_register_default(self):
self._check_registration(preferred=None)

def test_register_preferred(self):
self._check_registration(preferred=True)


if __name__=='__main__':
unittest.main()