Skip to content

bpo-45407: Remove outdated XXX comment from Struct___init___impl #28805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 8, 2021

Conversation

youknowone
Copy link
Contributor

@youknowone youknowone commented Oct 7, 2021

Struct___init___impl had XXX comment to use buffer protocol for there.
This patch it by falling back to buffer protocol when the given object is neither unicode nor bytes.
remove only comment by following the comment of bpo-45407

https://bugs.python.org/issue45407

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@youknowone

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@youknowone youknowone changed the title Support buffer interface for _struct.Struct.__init__ bpo-45407: Support buffer interface for _struct.Struct.__init__ Oct 7, 2021
@youknowone youknowone force-pushed the fix-struct__init__impl-xxx branch from b497650 to 7fa1c6a Compare October 7, 2021 17:52
Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As @serhiy-storchaka commented on the issue, please remove the comment only rather than support buffer protocol.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :)

@corona10 corona10 changed the title bpo-45407: Support buffer interface for _struct.Struct.__init__ bpo-45407: Remove comment about supporting buffer interface, Oct 8, 2021
@corona10 corona10 changed the title bpo-45407: Remove comment about supporting buffer interface, bpo-45407: Remove comment about supporting buffer interface. Oct 8, 2021
@corona10 corona10 changed the title bpo-45407: Remove comment about supporting buffer interface. bpo-45407: Remove outdated XXX comment from Struct___init___impl Oct 8, 2021
@corona10 corona10 merged commit 9f7a94f into python:main Oct 8, 2021
@youknowone youknowone deleted the fix-struct__init__impl-xxx branch October 12, 2021 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants