bpo-30853: IDLE: Convert font and general vars to use VarTrace #2914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlouielu
reviewed
Jul 28, 2017
|
|
||
| if not _utest: | ||
| self.grab_set() | ||
| self.wm_deiconify() | ||
| self.wait_window() | ||
|
|
||
|
|
There was a problem hiding this comment.
Class method only need one blank line, so this is no need to changed.
csabella
commented
Jul 28, 2017
terryjreedy
approved these changes
Jul 28, 2017
| self.builtin_theme = tracers.add( | ||
| StringVar(parent), self.var_changed_builtin_theme) | ||
| self.custom_theme = tracers.add( | ||
| StringVar(parent), self.var_changed_custom_theme) | ||
| self.fg_bg_toggle = BooleanVar(parent) |
There was a problem hiding this comment.
It is now obvious that fg_bg_toggle is not traced, others are. A plus for the change.
terryjreedy
reviewed
Jul 28, 2017
| @@ -75,13 +76,15 @@ def __init__(self, parent, title='', _htest=False, _utest=False): | |||
| # self.bind('<Alt-a>', self.Apply) #apply changes, save | |||
| # self.bind('<F1>', self.Help) #context help | |||
| self.load_configs() | |||
| self.attach_var_callbacks() # Avoid callbacks during load_configs. | |||
| # Avoid callbacks during load_configs. | |||
There was a problem hiding this comment.
We must remember this when reviewing and writing tests for the load functions.
terryjreedy
pushed a commit
to terryjreedy/cpython
that referenced
this pull request
Jul 28, 2017
…ythonGH-2914) Instance tracers manages pairs consisting of a tk variable and a callback function. When tracing is turned on, setting the variable calls the function. Test coverage for the new class is 100%. (cherry picked from commit 5b59154)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue30853