bpo-45548: Some test modules must be built as shared libs (GH-29268) #29268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some test cases don't work when test modules are static extensions. Add dependency on Modules/config.c to trigger a rebuild whenever a module build type is changed. ``makesetup`` puts shared extensions into ``Modules/`` directory. Create symlinks from pybuilddir so the extensions can be imported. Note: It is not possible to use the content of pybuilddir.txt as a build target. Makefile evaluates target variables in the first pass. The pybuilddir.txt file does not exist at that point. Signed-off-by: Christian Heimes <[email protected]>
gareth-rees
reviewed
Oct 28, 2021
tiran
changed the title
zware
reviewed
Oct 29, 2021
| @@ -507,6 +507,13 @@ Build Changes | |||
| except empty tuple singleton. | |||
| (Contributed by Christian Heimes in :issue:`45522`) | |||
|
|
|||
| * ``Modules/Setup`` and ``Modules/makesetup`` have been improved and tied up. | |||
There was a problem hiding this comment.
Suggested change
| * ``Modules/Setup`` and ``Modules/makesetup`` have been improved and tied up. | |
| * ``Modules/Setup`` and ``Modules/makesetup`` have been improved and tidied up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some test cases don't work when test modules are static extensions.
Add dependency on Modules/config.c to trigger a rebuild whenever a
module build type is changed.
makesetupputs shared extensions intoModules/directory. Createsymlinks from pybuilddir so the extensions can be imported.
Note: It is not possible to use the content of pybuilddir.txt as a build
target. Makefile evaluates target variables in the first pass. The
pybuilddir.txt file does not exist at that point.
Signed-off-by: Christian Heimes [email protected]
https://bugs.python.org/issue45548