-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
bpo-45633 Fix typo in extending/newtypes documentation #29318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). CLA MissingOur records indicate the following people have not signed the CLA: For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @dmitrysmirnov931!
You need to sign CLA to be able to contribute.
Also, don't be scared of news
CI failure. I guess this is a good candidate for skip:news
label (it will be done on merge by someone else) 🙂
Congrats on your first PR to CPython! 🎉
@sobolevn Yeah, thank you for sharing the issue! I have already signed the CLA actually, I'm waiting now for it to be processed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you.
Thanks @dmitrysmirnov931 for the PR, and @Fidget-Spinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10. |
GH-29364 is a backport of this pull request to the 3.10 branch. |
(cherry picked from commit 454cdb9) Co-authored-by: Dmitry Smirnov <[email protected]>
(cherry picked from commit 454cdb9) Co-authored-by: Dmitry Smirnov <[email protected]>
GH-29365 is a backport of this pull request to the 3.9 branch. |
(cherry picked from commit 454cdb9) Co-authored-by: Dmitry Smirnov <[email protected]>
(cherry picked from commit 454cdb9) Co-authored-by: Dmitry Smirnov <[email protected]>
https://bugs.python.org/issue45633