Skip to content

bpo-45633 Fix typo in extending/newtypes documentation #29318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 2, 2021
Merged

bpo-45633 Fix typo in extending/newtypes documentation #29318

merged 1 commit into from
Nov 2, 2021

Conversation

dmitrysmirnov931
Copy link
Contributor

@dmitrysmirnov931 dmitrysmirnov931 commented Oct 29, 2021

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@dmitrysmirnov931

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @dmitrysmirnov931!

You need to sign CLA to be able to contribute.
Also, don't be scared of news CI failure. I guess this is a good candidate for skip:news label (it will be done on merge by someone else) 🙂

Congrats on your first PR to CPython! 🎉

@dmitrysmirnov931
Copy link
Contributor Author

@sobolevn Yeah, thank you for sharing the issue! I have already signed the CLA actually, I'm waiting now for it to be processed

Copy link
Member

@Fidget-Spinner Fidget-Spinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@miss-islington
Copy link
Contributor

Thanks @dmitrysmirnov931 for the PR, and @Fidget-Spinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-29364 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Nov 2, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 2, 2021
(cherry picked from commit 454cdb9)

Co-authored-by: Dmitry Smirnov <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 2, 2021
(cherry picked from commit 454cdb9)

Co-authored-by: Dmitry Smirnov <[email protected]>
@bedevere-bot
Copy link

GH-29365 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Nov 2, 2021
@dmitrysmirnov931 dmitrysmirnov931 deleted the fix-issue-45633 branch November 2, 2021 14:49
Fidget-Spinner pushed a commit that referenced this pull request Nov 3, 2021
(cherry picked from commit 454cdb9)

Co-authored-by: Dmitry Smirnov <[email protected]>
Fidget-Spinner pushed a commit that referenced this pull request Nov 3, 2021
(cherry picked from commit 454cdb9)

Co-authored-by: Dmitry Smirnov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants