Skip to content

bpo-45792: Fix contextvar.Token's intersphinx FQN #29533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 12, 2021

Conversation

hynek
Copy link
Member

@hynek hynek commented Nov 12, 2021

Since .. module:: contextvars sets the module using .. class:: contextvars.Token, intersphinx records it as contextvars.contextvars.Token.

https://bugs.python.org/issue45792

Since `.. module:: contextvars` sets the module using `.. class:: contextvars.Token`, intersphinx records it as `contextvars.contextvars.Token`.
Copy link
Contributor

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@asvetlov asvetlov merged commit e501d70 into python:main Nov 12, 2021
@miss-islington
Copy link
Contributor

Thanks @hynek for the PR, and @asvetlov for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8, 3.9, 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 12, 2021
Since `.. module:: contextvars` sets the module using `.. class:: contextvars.Token`, intersphinx records it as `contextvars.contextvars.Token`.
(cherry picked from commit e501d70)

Co-authored-by: Hynek Schlawack <[email protected]>
@bedevere-bot
Copy link

GH-29535 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Nov 12, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 12, 2021
Since `.. module:: contextvars` sets the module using `.. class:: contextvars.Token`, intersphinx records it as `contextvars.contextvars.Token`.
(cherry picked from commit e501d70)

Co-authored-by: Hynek Schlawack <[email protected]>
@bedevere-bot
Copy link

GH-29536 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Nov 12, 2021
@bedevere-bot
Copy link

GH-29537 is a backport of this pull request to the 3.8 branch.

@bedevere-bot
Copy link

GH-29538 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 12, 2021
Since `.. module:: contextvars` sets the module using `.. class:: contextvars.Token`, intersphinx records it as `contextvars.contextvars.Token`.
(cherry picked from commit e501d70)

Co-authored-by: Hynek Schlawack <[email protected]>
asvetlov pushed a commit that referenced this pull request Nov 12, 2021
Since `.. module:: contextvars` sets the module using `.. class:: contextvars.Token`, intersphinx records it as `contextvars.contextvars.Token`.
(cherry picked from commit e501d70)

Co-authored-by: Hynek Schlawack <[email protected]>

Co-authored-by: Hynek Schlawack <[email protected]>
asvetlov pushed a commit that referenced this pull request Nov 12, 2021
Since `.. module:: contextvars` sets the module using `.. class:: contextvars.Token`, intersphinx records it as `contextvars.contextvars.Token`.
(cherry picked from commit e501d70)

Co-authored-by: Hynek Schlawack <[email protected]>

Co-authored-by: Hynek Schlawack <[email protected]>
@hynek hynek deleted the bpo-45792 branch November 12, 2021 11:27
ambv pushed a commit that referenced this pull request Nov 16, 2021
Since `.. module:: contextvars` sets the module using `.. class:: contextvars.Token`, intersphinx records it as `contextvars.contextvars.Token`.
(cherry picked from commit e501d70)

Co-authored-by: Hynek Schlawack <[email protected]>
remykarem pushed a commit to remykarem/cpython that referenced this pull request Dec 7, 2021
Since `.. module:: contextvars` sets the module using `.. class:: contextvars.Token`, intersphinx records it as `contextvars.contextvars.Token`.
remykarem pushed a commit to remykarem/cpython that referenced this pull request Jan 30, 2022
Since `.. module:: contextvars` sets the module using `.. class:: contextvars.Token`, intersphinx records it as `contextvars.contextvars.Token`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants