bpo-45915: use fcntl(fd, F_GETFD) in is_valid_fd() (GH-29821) #29821
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christian Heimes <[email protected]>
tiran
added
the
🔨 test-with-buildbots
bedevere-bot
removed
the
🔨 test-with-buildbots
corona10
reviewed
Nov 28, 2021
Python/pylifecycle.c
Outdated
| @@ -2139,6 +2145,12 @@ is_valid_fd(int fd) | |||
| if (fd < 0) { | |||
| return 0; | |||
| } | |||
| #ifdef F_GETFD | |||
There was a problem hiding this comment.
macOS also supports F_GETFD flag also.
On my macOS, all tests are passed with changes to use F_GETFD.
bpo-30225: On macOS Tiger, when stdout is redirected to a pipe and the other
macOS Tiger is 10.4, we provide installers for 10.9+ nowadays.
https://www.python.org/downloads/release/python-3100/
There was a problem hiding this comment.
So I would like to suggest changing the code to support macOS also.
tiran
force-pushed
the
bpo-45915-valid-fd
branch
from
c93fa66 to
70ca98b
Compare
tiran
changed the title
Why restricting the change to a few plaforms if it's faster? |
|
I have no means to test this on other platforms. I know it works on Linux and Dong-hee told me it works on macOS. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Christian Heimes [email protected]
https://bugs.python.org/issue45915