Skip to content

Correct word order #2993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 3, 2017
Merged

Correct word order #2993

merged 1 commit into from
Aug 3, 2017

Conversation

mivade
Copy link
Contributor

@mivade mivade commented Aug 3, 2017

No description provided.

@mivade mivade requested a review from 1st1 as a code owner August 3, 2017 13:56
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@Mariatta Mariatta added needs backport to 3.6 skip issue docs Documentation in the Doc dir labels Aug 3, 2017
Mariatta
Mariatta approved these changes Aug 3, 2017
View reviewed changes
Copy link
Member

@Mariatta Mariatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right: 'not only is it ... ' is grammatically correct :)
Thanks!

@Mariatta Mariatta merged commit 87c3c5d into python:master Aug 3, 2017
@Mariatta
Copy link
Member

Mariatta commented Aug 3, 2017

Thanks @mivade and congrats on your first contribution to CPython 🌮

Mariatta pushed a commit to Mariatta/cpython that referenced this pull request Aug 3, 2017
@mivade @Mariatta
[3.6] Improve grammar in asyncio documentation (pythonGH-2993)
aa15f48 
"not only is it .." is the correct form, as opposed to:
"not only it is ..."
(cherry picked from commit 87c3c5d)
@bedevere-bot
Copy link

GH-2994 is a backport of this pull request to the 3.6 branch.

Mariatta added a commit that referenced this pull request Aug 3, 2017
@Mariatta
[3.6] Improve grammar in asyncio documentation (GH-2993) (GH-2994)
9b3abac 
"not only is it .." is the correct form, as opposed to:
"not only it is ..."
(cherry picked from commit 87c3c5d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mariatta Mariatta Mariatta approved these changes

@1st1 1st1 Awaiting requested review from 1st1

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mivade @the-knights-who-say-ni @Mariatta @bedevere-bot