-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
bpo-35821: Fix restructuredtext code formatting in logging.rst #29963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@vsajip GH-29841 caused
|
Merging this to unblock other things. Thanks @bateller for taking a look. |
Thanks @Fidget-Spinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10. |
…nGH-29963) (cherry picked from commit c7e7a4b) Co-authored-by: Ken Jin <[email protected]>
…nGH-29963) (cherry picked from commit c7e7a4b) Co-authored-by: Ken Jin <[email protected]>
GH-29965 is a backport of this pull request to the 3.10 branch. |
GH-29966 is a backport of this pull request to the 3.9 branch. |
…GH-29963) (GH-29965) (cherry picked from commit c7e7a4b) Co-authored-by: Ken Jin <[email protected]> Automerge-Triggered-By: GH:Fidget-Spinner
) (cherry picked from commit c7e7a4b) Co-authored-by: Ken Jin <[email protected]>
@Fidget-Spinner Sorry, missed that. How come the Docs build on GH-29841 reported success? I didn't check the Azure build, because often seems to fail for no apparent reason and with no diagnostics 😞 |
@vsajip no worries! Docs build doesn't seem to run rstlint. I suspect that's because rstlint previously generated many false positives, so we disabled that for normal docs builds. @JulienPalard probably knows more about this than I do. |
So the error showed only on the Azure build. or somewhere else as well? |
Only on the Azure build. GH docs builds were fine. |
Adding a bit of context: Previously I missed the fact that the azure pipeline was ~ignored and the .github/workflow/doc was not running |
https://bugs.python.org/issue35821