Skip to content

gh-87264: tarfile list() method does not show file type. #29974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

gh-87264: tarfile list() method does not show file type. #29974

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
139d753
Fix for Issue43098 tarfile list() method does not show file type.
Dec 7, 2021
42f5352
Merge branch 'main' into tarfile-fix
AlexWaygood Nov 26, 2022
37c922c
📜🤖 Added by blurb_it.
blurb-it[bot] Nov 27, 2022
fc37df1
Condense blurb by omitting example and adding text
terryjreedy Nov 28, 2022
f31d630
Merge branch 'python:main' into tarfile-fix
val-shkolnikov Nov 28, 2022
5b819fb
Update test_tarfile.py
val-shkolnikov Nov 28, 2022
e90da27
Merge branch 'main' into tarfile-fix
val-shkolnikov Nov 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion Lib/tarfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1915,13 +1915,18 @@ def list(self, verbose=True, *, members=None):
output is produced. `members' is optional and must be a subset of the
list returned by getmembers().
"""
# Convert tarinfo type to stat type.
type2mode = {REGTYPE: stat.S_IFREG, SYMTYPE: stat.S_IFLNK,
FIFOTYPE: stat.S_IFIFO, CHRTYPE: stat.S_IFCHR,
DIRTYPE: stat.S_IFDIR, BLKTYPE: stat.S_IFBLK}
self._check()

if members is None:
members = self
for tarinfo in members:
if verbose:
_safe_print(stat.filemode(tarinfo.mode))
modetype = type2mode.get(tarinfo.type, 0)
_safe_print(stat.filemode(modetype | tarinfo.mode))
_safe_print("%s/%s" % (tarinfo.uname or tarinfo.uid,
tarinfo.gname or tarinfo.gid))
if tarinfo.ischr() or tarinfo.isblk():
Expand Down