Skip to content

bpo-46008: Make runtime-global object/type lifecycle functions and state consistent. #29998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 28 commits into from
Dec 9, 2021
Merged

bpo-46008: Make runtime-global object/type lifecycle functions and state consistent. #29998

merged 28 commits into from
Dec 9, 2021

Conversation

ericsnowcurrently
Copy link
Member

@ericsnowcurrently ericsnowcurrently commented Dec 9, 2021 •
edited
Loading

This change helps in the following ways:

  • ensures type-related init functions focus strictly on one of the three aspects (state, objects, types)
  • passes in PyInterprterState * to all those functions, simplifying work on moving types/objects/state to the interpreter
  • consistent naming conventions help make what's going on more clear
  • keeping API related to a type in the corresponding header file makes it more obvious where to look for it

Note that this PR is strictly renames and moving code around.

https://bugs.python.org/issue46008

@ericsnowcurrently
pycore_init_singletons() -> pycore_init_global_objects().
db48819
@ericsnowcurrently
Clean up runtime lifecycle for types in general.
32cc38c
@ericsnowcurrently
Clean up runtime lifecycle for PyLongObject.
b62c472
@ericsnowcurrently
Clean up runtime lifecycle for PyStructSequence.
fec45a2
@ericsnowcurrently
Clean up runtime lifecycle for PyUnicodeObject.
69aab8c
@ericsnowcurrently
Clean up runtime lifecycle for PyFloatObject.
817cd04
@ericsnowcurrently
Clean up runtime lifecycle for PyBytesObject.
7565f16
@ericsnowcurrently
Clean up runtime lifecycle for PyTupleObject.
d4e3046
@ericsnowcurrently
Clean up runtime lifecycle for context/hamt types.
0ee2251
@ericsnowcurrently
Clean up runtime lifecycle for exception types.
04fc6f6
@ericsnowcurrently
Clean up runtime lifecycle for error handling types.
bdf548b
@ericsnowcurrently
Clean up runtime lifecycle for PyFrameObject.
b7ca4bb
@ericsnowcurrently
Clean up runtime lifecycle for PyDictObject.
fcd7753
@ericsnowcurrently
Clean up runtime lifecycle for PyListObject.
d1b1718
@ericsnowcurrently
Clean up runtime lifecycle for PySliceObject.
bab319a
@ericsnowcurrently
Clean up runtime lifecycle for PyAsyncGenObject.
c50952b
@ericsnowcurrently
Move unicode-related API to the correct header file.
cd3c419
@ericsnowcurrently
Move float-related API to the correct header file.
828f6e4
@ericsnowcurrently
Move tuple-related API to the correct header file.
0120a4e
@ericsnowcurrently
Move list-related API to the correct header file.
11cf9a7
@ericsnowcurrently
Move dict-related API to the correct header file.
cbde112
@ericsnowcurrently
Move generator-related API to the correct header file.
387c9fa
@ericsnowcurrently
Move context-related API to the correct header file.
860917b
@ericsnowcurrently
Move bytes-related API to the correct header file.
0285089
@ericsnowcurrently
Move exceptions-related API to the correct header file.
88a2262
@ericsnowcurrently
Move type-related API to the correct header file.
946086d
@ericsnowcurrently ericsnowcurrently removed request for a team, 1st1 and markshannon December 9, 2021 01:05
@ericsnowcurrently ericsnowcurrently merged commit c8749b5 into python:main Dec 9, 2021
@ericsnowcurrently ericsnowcurrently deleted the global-objects-cleanup branch December 9, 2021 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ericsnowcurrently @the-knights-who-say-ni @bedevere-bot